vec to f a
#420
Merged
vec to f a
#420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julialongtin
reviewed
May 7, 2022
| @@ -35,7 +35,7 @@ import Test.QuickCheck | |||
| forAll) | |||
| import Data.Foldable ( for_ ) | |||
| import Test.Hspec.QuickCheck (prop) | |||
| import Linear (V2(V2), V3(V3), V4(V4), (^*) , Epsilon(nearZero)) | |||
There was a problem hiding this comment.
isn't removing this going to cause problems with values really close to zero?
There was a problem hiding this comment.
Wasn't able to hit a problem with it even with quite large --qc-max-success. It was only added recently to fix disabled scaling property in 7eff263#diff-cb79804fa5faf09727f9120b83f037c50a213c44faf3058e604a42fccc967655L138-R143 but this is more elegant since we can just use Eq now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands
vectof aand addsApplicativeandEqconstraints.Allows us to drop some redundancy and treat our previous
vecas functors. Additionally some identities liketranslate (pure 0)are now discarded.